Feature ap draw #3285
Merged
Feature ap draw #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
robluo
force-pushed
the
feature-ap-draw
branch
from
e026e80 to
e53ab81
Compare
robluo
force-pushed
the
feature-ap-draw
branch
from
a10f497 to
7eddb5c
Compare
AlexandreSinger
requested changes
Sep 30, 2025
robluo
force-pushed
the
feature-ap-draw
branch
from
7eddb5c to
5b2a7c4
Compare
AlexandreSinger
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
LGTM
@robluo Can you please resolve the conflicts and then I think this is good to merge.
This will not break place and route drawing and it creates a initial world of different dimension than place and route drawing
No more segfault when clicking. Added after solve and after legalization draw.
skip set_initial_world when no display
now in ap, there are no NOGRAPHCIS macro
moved print message inside of update_graphics
robluo
force-pushed
the
feature-ap-draw
branch
from
f6bfade to
84622b8
Compare
|
@robluo Your PR broke CI. This can happen when there is a merge conflict post-the-fact. When you rebased your branch, you may have rebased onto an older version of VTR! That can cause some funny stuff like that to occur. I had to revert your PR to keep master working. You will need to re-raise this code in another PR. Sorry for the pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now able to draw analytical placement
Description
Motivation and Context
To give more insight to AP flow
How Has This Been Tested?
By hand
Types of changes
Checklist: